Add test for client request with and without trailing slash. #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
More precisely, the behavior toggled, so before #520 the trailing slash was matching, now the non-trailing slash is matching. Hope the test can point out the difference. |
|
thank you for sharing your thoughts and providing a test. Given the number of reports of problems after fixing a security issue; i am now strongly considering making the "trailing slash handling" a configuration option. The old behavior being the default with the option to change the behaviour to meet the security request. |
|
Thanks @emicklei. I am looking forward to whatever route this problem will take and wait with the update until a decision was made. The config option sounds like a reasonable way to go in order to maintain client compatibility. |
emicklei
added a commit
that referenced
this pull request
Aug 5, 2023
* allow multiple samples for Write, issue #514 * update changelog * chore: example handling request parameters with httpin (#518) * use path package to join slash fragments #519 (#520) * update hist * update example openapi to use 3.10.1 * Add test for client request with and without trailing slash. (#522) * Add test for client request with and without trailing slash. * Correction. * introduce MergePathStrategy * Revert "introduce MergePathStrategy" This reverts commit 709cf80. * introduce MergePathStrategy for #521 #519 (#523) * introduce MergePathStrategy for #521 #519 * update readme, set default to new strategy, add extra test * link to security issue * update change hist * add hello world with TrimSlashStrategy * two route example * examples to show differences #519 * more route examples #519 * add examples for issue519 with path in root * remove obsolete swagger example * Update README.md remover swagger12 mention * allow multiple samples for Write, issue #514 --------- Co-authored-by: Ggicci <[email protected]> Co-authored-by: Gerrit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #520 clients receive different responses depending on a trailing slash in the requested path. This did not matter before, so this was a breaking change.
I wrote a small reproducer test to show the difference before and after 05c4911.
Is this expected behavior? It breaks quite a lot of our stuff. 🙈