Fix app installation on the simulator #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've only tested this on the simulator and the app store appears to be down now, hence the handling of the 404 response from the demo server. |
nomis
changed the title
nomis
changed the title
|
The app store is now working again, if you could have a test of this and let u know if its working it'd be appreciated :) |
|
I've tested this on the badge and it works |
Python's tarfile doesn't append a "/" to directory names like MicroPython does, so the root directory detection fails. Normalise the names by removing the "/" and then adding it back when returning the root directory name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python's tarfile doesn't append a "/" to directory names like MicroPython does, so the root directory detection fails. Normalise the names by removing the "/" and then adding it back when returning the root directory name.