-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic app launcher #22
Conversation
It seems that the launcher is not in the branch?
|
Oops, thanks @Molive-0. Added now. |
@MatthewWilkes Does this work in the simulator? I'm trying to get our app to boot in the launcher but it seems that the "/apps" directory it checks is actually "/apps", as in next to "/usr", "/bin" and "/home" on my root directory. |
print(self._apps) | ||
if app is None: | ||
print(f"Creating app {app_id}...") | ||
module = __import__(module_name, None, None, (fn,)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently this will try to import the app name as-is. However, since the apps are all in the /apps/
folder and that is not in the sys.path
this will fail. This should be replaced with __import__('apps.' + module_name, [...]
or similar. Alternatively you can append /apps/
to the sys.path
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Thanks, I was just coming in to look at this. I assumed it had been a simulator path issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem! Glad I could help 😁
Going to merge this for now. Think it's a step forward, and want to get the simulator out. |
No description provided.