Increase VBATMIN to 3 volts #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does not change the battery voltage. It only changes the reported voltage from the battery state of charge measurement. |
|
Serves me right for assuming it would be simple. Having gone back and done a little more digging it looks like I'll need to edit bq25895.c/h? I'll have a poke and redo the pull request once I've worked out what's going on |
|
I've commented on the issue about this, but I'm happy for this to go in as it does improve the Batterylevel() while I'm giving it an overhaul. maybe increase it to 3.5V to match the PMIC min voltage. |
|
I've increased it to 3.5V. Thanks! |
ChrisDick
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases the minimum battery voltage to the 3 volt minimum specified in its datasheet, as discussed in issue #175