update API and examples for egpio #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fix units of Battery current.
Merged
npentrel
approved these changes
Jun 30, 2024
|
I renamed it to match the name of the module. Do you think that matters? not sure it's wise changing the name in the sw, but we could while it's still in rc. I don't mind either way, happy to replace all occurrences in the docs if that makes more sense to keep consistency. Another solution is to make them all eGPIO except in the methods section and make that one egpio.ePin? |
|
@ChrisDick let's go with your suggestion and make them all eGPIO except in the methods section and make that one |
|
Merging for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fix units of Battery current.
Description
add new elements to the API for the the LS gpio and update examples. correct the units for the battery charge current from mA to A.