Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification for minor rpc errors #835

Closed
splix opened this issue Nov 7, 2018 · 1 comment · Fixed by #883
Closed

Notification for minor rpc errors #835

splix opened this issue Nov 7, 2018 · 1 comment · Fixed by #883
Assignees
@splix

Comments

@splix
Copy link
Member

splix commented Nov 7, 2018

Do not show Error Dialog window for minor http connection errors, but show a simple disappearing notification. For example https://material-ui.com/demos/snackbars/

Keep error window only when a serious error happened, for example when Wallet was unable to send a new transaction to a node.
@splix splix added help wanted Available to take (please mention in comment if you want to work on it) good first issue labels Nov 7, 2018
@splix
Copy link
Member Author

splix commented Jan 21, 2019

Should fix all "Failed to fetch"

rel #878 #875 #874 #873 #871 #870 #869 #867 #865 #855 #854 #853 #851 #848 #847 #845 #844 #839 #832 #827 #825 #817 #785 #784 #782 #781 #780 #779 #775 #774 #770 #769 #767 #766 #764 #760 #749 #746 #745 #744 #742 #741 #740 #738 #737 #736 #733 #732 #725 #723 #719 #706 #704 #703 #701 #695 #694 #692 #687 #685 #684 #676 #670

@splix splix added WIP Work in progress and removed good first issue help wanted Available to take (please mention in comment if you want to work on it) labels Jan 21, 2019
splix added a commit that referenced this issue Jan 21, 2019
@splix
problem: too annoying "Fetch Error" for a remote RPC
94bafbf 
solution: display it as a temp notification
rel: fix #835
@splix splix mentioned this issue Jan 21, 2019
Merged
@ghost ghost assigned splix Jan 21, 2019
@ghost ghost added the review label Jan 21, 2019
gagarin55 pushed a commit that referenced this issue Jan 22, 2019
@splix @gagarin55
problem: too annoying "Fetch Error" for a remote RPC (#883)
f0c635b 
* problem: too annoying "Fetch Error" for a remote RPC
solution: display it as a temp notification
rel: fix #835

* problem: unhandled Error on initial Sync
splix added a commit that referenced this issue Jan 28, 2019
@splix
problem: error window when check for remote version
af14f9c 
rel: #835
This was referenced Feb 27, 2019
Closed
Closed
@splix splix removed review WIP Work in progress labels Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@splix splix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

problem: too annoying "Fetch Error" for a remote RPC emeraldpay/emerald-wallet
1 participant
@splix