-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable prettier in ci #1388
Enable prettier in ci #1388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the motivation to change quotes in template/html files?
as far as I can tell default in ember is double quotes in templates single for js files
I didn't change the prettier config -- this PR only hooks up prettier to C.I. and package.json#scripts. -- if there is a better config to use, lemme know. |
5dcf4fd
to
0a72da2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we discussed this in the meeting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
5ff162c
to
585811b
Compare
Extracted from: #1384
since the editorconfig tooling may be suspicious (or misconfigured)