Merge pull request #1359 from mansona/bang-requests

Ignore resolve requests that start with !
embroider-build · Feb 15, 2023 · 565e9e5 · 565e9e5
2 parents 07818cc + 6861242
commit 565e9e5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/packages/webpack/src/webpack-resolver-plugin.ts b/packages/webpack/src/webpack-resolver-plugin.ts
@@ -110,7 +110,8 @@ class WebpackModuleRequest implements ModuleRequest {
       typeof state.context === 'string' &&
       typeof state.contextInfo?.issuer === 'string' &&
       state.contextInfo.issuer !== '' &&
-      !state.request.startsWith(virtualLoaderName) // prevents recursion on requests we have already sent to our virtual loader
+      !state.request.startsWith(virtualLoaderName) && // prevents recursion on requests we have already sent to our virtual loader
+      !state.request.startsWith('!') // ignores internal webpack resolvers
     ) {
       return new WebpackModuleRequest(state);
     }

diff --git a/tests/scenarios/v2-addon-test.ts b/tests/scenarios/v2-addon-test.ts
@@ -22,12 +22,14 @@ appScenarios
           import Component from '@glimmer/component';
           import { hbs } from 'ember-cli-htmlbars';
           import { setComponentTemplate } from '@ember/component';
+          import './example-component.css';
           const TEMPLATE = hbs('<div data-test-example>{{this.message}}</div>')
           export default class ExampleComponent extends Component {
             message = "it worked"
           }
           setComponentTemplate(TEMPLATE, ExampleComponent);
         `,
+        'example-component.css': '/* not empty */ h1 { color: red }',
       },
       'import-from-npm.js': `
         export default async function() {