Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
you can see in #621 that CI is currently failing because of a floating dependency on minimatch
this minimatch dependency floated because of the dependency chain ember-cli-babel@8 > babel-plugin-module-resolver@5 > glob@9 > minimatch@8
Edit: it turns out the original culprit is the fact that
@embroider/util
bumped the ember-cli-babel major version without doing a major themselves 😞 Looking at the full list ofnpm why minimatch@8
you can see why:Another edit: it turns out that there were other dependencies of glob@9 that needed a newer node version so instead of pinning minimatch I just pinned glob to the pre 9 version 👍