Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix glob version on lts tests #622

Merged
merged 1 commit into from
May 27, 2024
Merged

fix glob version on lts tests #622

merged 1 commit into from
May 27, 2024

Conversation

mansona
Copy link
Member

@mansona mansona commented Apr 22, 2024

you can see in #621 that CI is currently failing because of a floating dependency on minimatch

this minimatch dependency floated because of the dependency chain ember-cli-babel@8 > babel-plugin-module-resolver@5 > glob@9 > minimatch@8

Edit: it turns out the original culprit is the fact that @embroider/util bumped the ember-cli-babel major version without doing a major themselves 😞 Looking at the full list of npm why minimatch@8 you can see why:

[email protected] dev
../../node_modules/@embroider/util/node_modules/minimatch
  minimatch@"^8.0.2" from [email protected]
  ../../node_modules/@embroider/util/node_modules/glob
    glob@"^9.3.3" from [email protected]
    ../../node_modules/@embroider/util/node_modules/babel-plugin-module-resolver
      babel-plugin-module-resolver@"^5.0.0" from [email protected]
      ../../node_modules/@embroider/util/node_modules/ember-cli-babel
        ember-cli-babel@"^8.2.0" from @embroider/[email protected]
        ../../node_modules/@embroider/util
          @embroider/util@"^1.9.0" from @ember/[email protected]

Another edit: it turns out that there were other dependencies of glob@9 that needed a newer node version so instead of pinning minimatch I just pinned glob to the pre 9 version 👍

@mansona mansona force-pushed the fix-lts branch 3 times, most recently from 8ca32c9 to ccc3b2f Compare April 24, 2024 14:25
@mansona mansona changed the title fix minimatch version on lts tests fix glob version on lts tests Apr 24, 2024
@ef4 ef4 merged commit 89d4923 into main May 27, 2024
119 checks passed
@ef4 ef4 deleted the fix-lts branch May 27, 2024 13:15
@github-actions github-actions bot mentioned this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants