Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary verbatimModuleSyntax from tsconfig.json #276

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

SergeAstapov
Copy link
Contributor

verbatimModuleSyntax already turned on in @tsconfig/ember

verbatimModuleSyntax already turned on in `@tsconfig/ember`
@NullVoxPopuli NullVoxPopuli added the enhancement New feature or request label Mar 25, 2024
We don't want to include types dependencies in our compiled output, so tell TypeScript
to enforce using `import type` instead of `import` for Types.
*/
"verbatimModuleSyntax": true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment is present in the upstream setting: https://github.com/tsconfig/bases/blob/main/bases/ember.json#L17

@NullVoxPopuli NullVoxPopuli merged commit 7ef6a30 into embroider-build:main Mar 25, 2024
17 of 18 checks passed
@github-actions github-actions bot mentioned this pull request Mar 25, 2024
@SergeAstapov SergeAstapov deleted the patch-1 branch March 25, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants