Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart - Correct mountPath for config JSON #6

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

seanich
Copy link
Contributor

@seanich seanich commented Feb 4, 2020

Currently when specifying a custom configuration via the chart values the deployment will specify an invalid volume mount that will cause an error on pod startup (it tries to mount sftp.json to /app/config instead of /app/config/sftp.json.) This PR corrects that issue :)

@unguiculus
Copy link

Any chance this get merged soon?

@winromulus
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@winromulus
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@winromulus winromulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winromulus winromulus merged commit b2d8448 into emberstack:master Feb 18, 2020
@winromulus
Copy link
Contributor

@seanich @unguiculus - I sincerely apologise for the delay on this. I missed the notification and was on vacation for the past two weeks.
Thank you very much for your contribution!

@seanich
Copy link
Contributor Author

seanich commented Feb 19, 2020

Not a problem! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants