New load and sideload methods to align with ember-data APIs #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👏 🎉 |
|
Let's use |
|
scratch that - going with |
This allows us to test all versions of ED in the try config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides APIs for explicitly loading relationship data asynchronously via links or compound documents.
Added
model.sideload('relationship'): This will fetch the model and slideload the relationship. Since it's using JSON:API includes to fetch data it has the added benefit of fetching multiple relationships in one go (example:post.sideload('comments.author,favorites')). Wouldn't mind calling thisincludinginstead ofsideload.Added
model.load('relationship'): This will fetch the relationship using links, which means the client can now fetch data from URLs provided by the backend without using the include pattern. This is how Ember data works data today withget('relationship').WIP - This is some code and tests only. Docs and examples need to be updated.