fastboot-adapter fails when different domains are used: remove domain and protocol from shoebox key #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes!!! 👍 Thank you for taking care of this! |
|
Data beta has a bug, that's why tests are failing. I think this is safe to merge though |
|
@ryanto I just deployed my app with a dependency to the fork, which is running without issues so far. There should not be much that could go wrong (other than failing to provide a url at all - we could still add a check for that, but this would eventually prevent the fastboot-adapter from working at all anyway) |
|
Ok good to hear. I know we have this issue on embermap as well, so I'll give it a try there. |
|
Alright I published this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an ember is run in fastboot mode and the ember-data adapter contains a conditional to use an internal domain in fastboot mode (within the private network) and a public domain (used by the browser), ember-data-storefront fails to recognise data on the browser which is available in the shoebox.
Reason for this behaviour is that the full url (containing both the protocol and the host) is used to store the data within the shoebox. The browser now tries to lookup that data using its public domain, whereas all data on the fastboot server has been stored using the private domain.
This PR removes both the protocol as well as the domain from the url that is used within the shoebox key.