This repository was archived by the owner on Mar 22, 2019. It is now read-only.
Added section on model.save RFC #3537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrng
approved these changes
Aug 30, 2018
| @@ -41,8 +41,14 @@ Read more in the [rendered pull request on GitHub](https://github.com/emberjs/rf | |||
|
|
|||
| --- | |||
|
|
|||
| ## [SECTION TITLE](#section-url) | |||
| ## [RFC: I Promise You It's Good](#section-url) | |||
There was a problem hiding this comment.
Missed adding the link to the RFC replacing section-url
Also an emoji! 👌
jayjayjpg
reviewed
Aug 30, 2018
Alonski
reviewed
Aug 31, 2018
|
|
||
| The idea here is to make `DS.Model.save()` return an `RSVP.Promise` instead of a `PromiseObject`. This is to remove the dependency on promise proxies, improve async consistency and enable new functionality in Ember Data. | ||
|
|
||
| The only drawback of this is if you are already relying on this behaviour you’ll probably have to refactor your code to either use patterns like `async/await` or `ember-concurrency`. |
There was a problem hiding this comment.
Maybe add a link to the Ember Concurrency GitHub here?
jayjayjpg
approved these changes
Aug 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.