-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
@locks Looks like the preview link here isn't quite accurate for Netlify? |
04efd6f
to
07a2298
Compare
This public API replaces the intimate API of `_lookupFactory`, and additionally | ||
discourages developers from setting properies on classes returned from the | ||
container. For more information about this API see the [API | ||
docs](http://emberjs.com/api/classes/ContainerProxyMixin.html#method_factoryFor) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This documentation URL has no content, needs to be written per TODOs in the issue description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good as of emberjs/ember.js#15005
to a point in browsing history. See pull request [#14011](https://github.com/emberjs/ember.js/pull/14011) | ||
for more details. | ||
|
||
For more details on the upcoming changes in Ember.js 2.12, please review the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be Ember.js 2.13 ? and should it point to the 2.13 beta 1 instead of 2.12?
|
||
#### Deprecations in Ember Data 2.13 | ||
|
||
There are no planned deprecations for Ember Data 2.12. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ember Data 2.12 --> Ember Data 2.13
There are no planned deprecations for Ember Data 2.12. | ||
|
||
For more details on the upcoming changes in Ember Data 2.11, please review the | ||
[Ember Data 2.12.0-beta.1 release page](https://github.com/emberjs/data/releases/tag/v2.12.0-beta.1). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
|
||
### Upcoming Changes in Ember.js 2.13 | ||
|
||
Building on the addition of `featureFor` in Ember 2.12, Ember 2.13 will change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/featureFor/factoryFor/ ?
Ember Data is good to go. |
Confirm |
The latest beta of ember-cli-babel@6 takes advantage of the new `project.targets` API along with [babel-preset-env](https://github.com/babel/babel-preset-env) | ||
to allow applications to have significantly better control of exactly what is transpiled. `babel-preset-env` utilizes the [caniuse](http://caniuse.com/) and | ||
[@kangax]'s [ES6 compatibility database](https://kangax.github.io/compat-table/es6/) to know which features are available natively and which | ||
require transpilation. For example, with the proper targets configuration ember-cli-babel will no longer transpile `cosnt` / `let`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cosnt
=> const
74c70a2
to
923c6cf
Compare
2a22dc1
to
55d9851
Compare
introduces roughly 19MB to a freshly generated application's `node_modules` size. As the `npm` client has become more stable (3.x series and | ||
newer) this has seemed more and more wasteful. | ||
|
||
Starting with Ember CLI 2.12, `npm` is no longer a dependency of. If a suitable version of `npm` is present on the system, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of
can be removed
As of Ember CLI 2.11 a new application has no dependencies via `bower.json`. This means the dependency on `bower` itself is also potential bloat. | ||
Having `bower` | ||
as a dependency added roughly 21MB to a new application's total `node_modules` size. In Ember CLI 2.12, bower is only added as a dependency if a command | ||
requires `bower` and it is not already installed globally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is actually wrong, since we can't take advantage of globally installed bower
Thanks to [@hjdivad](https://github.com/hjdivad) for proposing and implementing this feature. Please read through [the RFC](https://github.com/ember-cli/rfcs/blob/master/complete/0091-addon-instrumentation-experimental-hooks.md) | ||
for more details. | ||
|
||
#### Target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Targets
?
damn, merged while I was reviewing... 😄 |
@Turbo87 ah thanks, I will open another PR |
Ship approvals
factoryFor
needs documentation 😱at: http://emberjs.com/api/classes/ContainerProxyMixin.html#method_factoryFor
0178
instead of#178
.There is no deprecation guide for component lifecycle args (RFC, issue)edit: It exists here, needs to be added to the 2.12 section.uuid
state property is not documented. See: Track unique history location states ember.js#14011. Not totally needed for 2.12 stable, needed for 2.13 stable.Checklist