Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deprecate proxies in ember-data #846

Merged
merged 6 commits into from
Aug 31, 2022
Merged

feat: deprecate proxies in ember-data #846

merged 6 commits into from
Aug 31, 2022

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Aug 18, 2022 •
edited
Loading

@runspired runspired added T-ember-data RFCs that impact the ember-data library T-deprecation labels Aug 18, 2022
@runspired runspired self-assigned this Aug 18, 2022
@runspired runspired mentioned this pull request Aug 18, 2022
Closed
@runspired
Copy link
Contributor Author

An addendum: this does not cover Model.errors. We'll tackle that in a separate RFC as it's a fairly ... complicated ... proxy that may struggle to be converted into a native proxy.

@runspired
Copy link
Contributor Author

The implementation for this is in emberjs/data#8134

snewcomer
snewcomer approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eggciting!

runspired
runspired commented Aug 24, 2022
View reviewed changes
text/0846-ember-data-deprecate-proxies.md Outdated Show resolved Hide resolved
text/0846-ember-data-deprecate-proxies.md Outdated Show resolved Hide resolved
text/0846-ember-data-deprecate-proxies.md Outdated Show resolved Hide resolved
runspired added a commit to emberjs/data that referenced this pull request Aug 25, 2022
@runspired
feat: deprecate proxies (implements emberjs/rfcs#846) (#8134)
fe56598 
* feat: deprecate proxies

* minor fixes, deprecate chains
@runspired runspired merged commit 1415b0f into emberjs:master Aug 31, 2022
@runspired runspired mentioned this pull request Sep 12, 2022
Merged
@jrjohnson jrjohnson mentioned this pull request Sep 19, 2022
Merged
@sandstrom
Copy link
Contributor

sandstrom commented Aug 9, 2023 •
edited
Loading

@snewcomer Don't have your email, so writing here. As you know, we've sponsored your work on Ember Data for a while.

I did a quick review of our sponsorships, and decided to stop or sponsorship, and shift that money over to @runspired (which we already sponsored, but with some additional money now). My understanding via a quick Google search is that you switched jobs a while back, and since then probably has had less time to spend on Ember Data. Which is totally understandable!

If you have time to spend on Ember Data in the future, just let me know, and I'm happy to reconsider.

Just wanted to write you a quick note to let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snewcomer snewcomer snewcomer approved these changes

Assignees

@runspired runspired

Labels
Final Comment Period T-deprecation T-ember-data RFCs that impact the ember-data library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@runspired @sandstrom @snewcomer