Friendly Errors

[nikz]

Hopefully I filled out everything correctly.

Thanks for looking at this! 😎

Here's a wee "friendly error" preview:

[alexspeller]

👍

[tim-evans]

It would be neat to provide something like Rail's filter_parameters if requests are shown.

[jcope2013]

a start emberjs/data#3862

[bmac]

Hi @nikz. I like this rfc a lot. Would you like to open a pr on the Ember Data repo where we can iterate on the implementation of the friendly-error-adapter code?

[bmac]

This technique may not work with multiple concurrent ajax requests. Instead I suspect we will need to pass the request or errorMessage as an argument to handleResponse.

[nikz]

Yeah, mostly a hack to avoid trying to drop too deeply into the ember-data code. Definitely better ways to do it!

[nikz]

@bmac awesome! I will do so over the weekend and cc you :)

[fivetanley]

Assigned an RFC number and merged in 6157685

@nikz's PR in emberjs/data#3930 was the implementation. Thank you so much!

[grapho]

I really like the idea of this RFC. However I also hold out hope that an AdapterError could hold an actual data payload.. for those of us that might receive an array of errors or a hash of error parameters? rather than (read: in addition too) just a serialized string of info?

[nikz]

@grapho Hiya! Remember this is just the default handler if you haven't specified anything else, mostly for debugging and error tracking.

If you use a blob of JSON then that'll be spit out, or if you're looking for more model validation things then a JSON API "errors" payload would work best.

[grapho]

@nikz yeah oops, i momentarily forgot that error payload can already get passed in... just ignore me ;)