Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove checks for no longer existing optional features #20722

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Remove checks for no longer existing optional features #20722

merged 3 commits into from
Aug 7, 2024

Conversation

boris-petrov
Copy link
Contributor

Fixes the issue described in this comment.

cc @ef4

@boris-petrov
Copy link
Contributor Author

I see also both are used in smoke-tests/app-template/config/optional-features.json - unsure if they have to still be there. Also, in packages/@ember/component/template-only.ts there is a comment about template-only-glimmer-components - perhaps it also must be changed.

@ef4 ef4 merged commit 85fa73f into emberjs:main Aug 7, 2024
26 checks passed
@boris-petrov boris-petrov deleted the remove-template-only-glimmer-components branch August 8, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NullVoxPopuli NullVoxPopuli NullVoxPopuli approved these changes

@anandfresh anandfresh anandfresh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@boris-petrov @NullVoxPopuli @anandfresh @ef4