[BUGFIX stable] TS lint-level error in mixins/-proxy.ts
#20429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there are two more instances flagged in |
Explicitly do a consistent return from a number of spots which TS 5.1 nightlies are catching, and which previous versions did not. In these cases, we explicitly return `undefined`, which is equivalent to the previous behavior.
chriskrycho
force-pushed
the
consistent-return
branch
from
e927038 to
6b386ae
Compare
chriskrycho
changed the title
mixins/-proxy.tsmixins/-proxy.ts
chriskrycho
changed the title
mixins/-proxy.tsmixins/-proxy.ts
dfreeman
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly do a consistent return from a number of spots which TS 5.1 nightlies are catching, and which previous versions did not. In these cases, we explicitly return
undefined, which is equivalent to the previous behavior.Fixes a lint-style error with TS nightly.