[CLEANUP beta] Update GlimmerVM to 0.81

[rwjblue]

High level breaking changes:

• removes deprecation of mutations during helper compute
• removes deprecation of mutations during unknownProperty
• @glimmer/integration-tests, @glimmer/manager, @glimmer/validator
  • #1330 Remove deprecated support for mutation after consumption during certain manager hooks (@snewcomer)
• @glimmer/manager
  • #1328 Remove deprecated Component Manager version 3.4 (@nlfurniss)
• @glimmer/integration-tests, @glimmer/manager
  • #1329 Remove deprecated Modifier Manager version 3.13 (@nlfurniss)

See full details here:

https://github.com/glimmerjs/glimmer-vm/releases/tag/v0.81.0

Closes #19735
Closes #19731

[snewcomer]

@rwjblue Does this PR need to be cherry-picked or copied into here?

#19735

[nlfurniss]

I think you'll need to cherry-pick #19731 to fix some failures

[rwjblue]

Thanks @snewcomer / @nlfurniss - I've merged both of those PR's into this branch.

[nlfurniss]

Looking into the failures and here is at least one fix:

glimmerjs/glimmer-vm#1343 (fixes 3/5 errors)

[nlfurniss]

And this diff fixes the rest of the tests (and I believe it's correct)

diff --git a/packages/@ember/-internals/glimmer/tests/integration/components/angle-bracket-invocation-test.js b/packages/@ember/-internals/glimmer/tests/integration/components/angle-bracket-invocation-test.js
index 34a696ab5..1bb86b5c4 100644
--- a/packages/@ember/-internals/glimmer/tests/integration/components/angle-bracket-invocation-test.js
+++ b/packages/@ember/-internals/glimmer/tests/integration/components/angle-bracket-invocation-test.js
@@ -9,7 +9,7 @@ import { Component } from '../../utils/helpers';
 
 class CustomModifierManager {
   constructor(owner) {
-    this.capabilities = modifierCapabilities('3.13');
+    this.capabilities = modifierCapabilities('3.22');
     this.owner = owner;
   }
 
diff --git a/packages/@ember/-internals/glimmer/tests/integration/custom-component-manager-test.js b/packages/@ember/-internals/glimmer/tests/integration/custom-component-manager-test.js
index c4d6552f3..62e9b576a 100644
--- a/packages/@ember/-internals/glimmer/tests/integration/custom-component-manager-test.js
+++ b/packages/@ember/-internals/glimmer/tests/integration/custom-component-manager-test.js
@@ -463,6 +463,7 @@ moduleFor(
           return EmberObject.create({
             capabilities: componentCapabilities('3.13', {
               asyncLifecycleCallbacks: true,
+              updateHook: true,
             }),
 
             createComponent(factory, args) {
@@ -668,6 +669,7 @@ moduleFor(
         capabilities: componentCapabilities('3.13', {
           destructor: true,
           asyncLifecycleCallbacks: true,
+          updateHook: true,
         }),
 
         createComponent(factory, args) {

[nlfurniss]

looks like only @test it does not resolve helpers with a . (period)' is failing

[snewcomer]

Yep I was debugging that on the glimmer side. There are some op codes that I was tracking down in glimmer. Perhaps will make some progress but if you happen to know, would love to chat about it.

[nlfurniss]

Yep I was debugging that on the glimmer side. There are some op codes that I was tracking down in glimmer. Perhaps will make some progress but if you happen to know, would love to chat about it.

Sadly not. Glimmer is like Swahili to me 😔

[snewcomer]

• from the discord channel

I'm struggling with what do to since we removed the this fallback. There is one failing test.

@test it does not resolve helpers with a . (period)

eg. {{hello.world}}

I believe the VM is in a bad state. I'm 👀 at GetFreeAsFallback. A few options I am thinking of and would love to hear your opinions.

1. Force an error in the compiler if we can't resolve a local block variable. Basically if we can't find a component/helper/etc/local block variable, we error to tell the user as much. This is a stricter stance, but one it seems we can take now since removing the this fallback.
2. Do not error while rendering {{hello.world}}. e.g. assertHTML('')

[rwjblue]

@ef4 is looking into the failing test here, to figure out what is going on. It is totally plausible that the test just isn't valid any longer, but it does seem strange that we don't get a better assertion / failure message.

[ef4]

After investigating I think the test failure is revealing a legitimate bug in glimmer-vm. The GetFreeAsFallback opcode is broken.

Here's a PR to try and remove it entirely instead: glimmerjs/glimmer-vm#1362

[ef4]

With the above glimmer-vm PR, there's still an exception in that test, but now it's a proper error and not a VM crash:

Error: Attempted to resolve a value in a strict mode template, but that value was not in scope: hello

I think the behavior is now correct, although the wording of the error message is misleading. When it was written, it could probably only be reached in strict mode. But now that the this fallback is removed it can be reached in certain positions even in loose mode. In this case, given that hello is a free variable, this:

{{hello.world}}

supports only strict resolution, since there's nowhere else it can come from, because we never supported globals resolution of this syntax.

[rwjblue]

Note: I'm working on rebasing now that glimmer-vm 0.83.1 is released

[rwjblue]

CI will fail until #19830 lands