-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation warning to Ember.assign #19649
Conversation
Rebased and pushed. Not sure why lint failed on a file I didn't edit 🤨 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one small tweak here, but I'd love another PR that actually removes the implementation in packages/@ember/polyfills/lib/assign.ts
. Now that we only support browsers that include Object.assign
we can basically do:
export default Object.assign;
(also removing the babel-plugin-transform-object-assign
usage)
Added that here, since it seems like it should be in one PR, but happy to move if you'd like. and the babel transform was removed in #19563 |
Looks good to me. I rebased to resolve a conflict and force pushed. |
Ember RFC #750 was approved; this implements it.
The
url
for the deprecation is optimistic (in that that page does not yet exist), let me know if I should handle that differently.