[FEATURE] Scopes down the mandatory setter #18961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scopes down the mandatory setter, like it was described in the [quest issue](#18769). It should only be applied when a value is being used as a dependency in a computed property or an observer.
|
Did a quick skim, looks good. I'd like to review in more detail, will try to do it over the weekend... |
rwjblue
approved these changes
May 14, 2020
This was referenced Jun 27, 2020
knownasilya
added a commit
to Strider-CD/strider
that referenced
this pull request
Aug 15, 2020
mandatory setter issue was fixed emberjs/ember.js#18961
knownasilya
added a commit
to Strider-CD/strider
that referenced
this pull request
Aug 16, 2020
mandatory setter issue was fixed emberjs/ember.js#18961
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scopes down the mandatory setter, like it was described in the quest issue. It should only be applied when a value is being used as a dependency in a computed property or an observer.