-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add support for public in-element
#18867
Conversation
Thank you for the help! I don't think this is wrapped in a feature flag, so I would like to see API documentation be merged with the implementation so we make sure any release with the feature also contains the documentation. I can help with it! |
@locks added a commit with the API docs! |
Travis build itself is green, but still shown here as pending. 🤔 |
in-element
in-element
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Thanks for getting this done 😄
Ah, one thing actually, could you add a canary feature flag that guards this? Shouldn't be too hard, it should probably just re-enable the transform that errors for |
@pzuraq done. Hope I got the usage of feature flags right, please re-review! |
@@ -20,6 +20,7 @@ export const DEFAULT_FEATURES = { | |||
EMBER_CUSTOM_COMPONENT_ARG_PROXY: true, | |||
EMBER_GLIMMER_SET_COMPONENT_TEMPLATE: true, | |||
EMBER_ROUTING_MODEL_ARG: true, | |||
EMBER_GLIMMER_IN_ELEMENT: null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's probably fine to enable by default in this PR too, since it's not a major refactor. The feature flag is mostly to give us a way to turn it off in case we do run into major issues during beta
. Will confirm though
Scratch that, we'll bring it up in the next core team meeting to enable, going through the standard process (checked with @rwjblue)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right. Now that you are mentioning this, I remember that I wanted to ask about this 😝
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, seems I was mistaken. Assuming travis passes I think this is good to go!
Travis seems to undergo maintenance, the build is not showing up here so far, but it is running here |
Thanks again @simonihmig! |
As per RFC287.
This does not yet add API docs, will follow in a separate PR{{-in-element}}
is slated for 4.0. The RFC suggested the next version after the next LTS, but given that the deprecation will be added at 3.19 at the earliest, I would think 4.0 seems appropriate (depending on how many more 3.x releases are expected)