Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start GlimmerVM 0.44.0 update #18454

Closed
wants to merge 28 commits into from

Conversation

knownasilya
Copy link
Contributor

@knownasilya knownasilya commented Oct 2, 2019

WIP

@knownasilya knownasilya changed the title fix: replace opaque with unknown chore: replace opaque with unknown Oct 2, 2019
@knownasilya
Copy link
Contributor Author

hum, will probably need to update glimmer-vm, so not as disconnected as I thought.

@knownasilya knownasilya changed the title chore: replace opaque with unknown Start GlimmerVM 0.39.1 update Oct 2, 2019
@pzuraq
Copy link
Contributor

pzuraq commented Oct 2, 2019

This is something we're planning on working on in the next couple of months, I think we decided it would probably make more sense to try to upgrade to the latest versions of Glimmer directly, but @chancancode and @wycats will have the most context here. Definitely glad you're getting this started though, thank you!

@pzuraq
Copy link
Contributor

pzuraq commented Oct 12, 2019

@knownasilya the last commit you pushed in particular is actually work that will have to be undone - on master, createTag is the default way of doing things now.

@knownasilya
Copy link
Contributor Author

@pzuraq do you recommend changing direction to update to latest?

@pzuraq
Copy link
Contributor

pzuraq commented Oct 12, 2019

Yeah, definitely. We won't be able to land an upgrade unless we get to the latest version, since all of the performance fixes we landed in 0.38.5-alpha.3 aren't available again until 0.42.2

@knownasilya knownasilya changed the title Start GlimmerVM 0.39.1 update Start GlimmerVM 0.44.0 update Nov 9, 2019
@knownasilya
Copy link
Contributor Author

Yay, fixed a couple tests.

@knownasilya
Copy link
Contributor Author

I have no idea what I'm doing 😂

@btecu
Copy link
Contributor

btecu commented Nov 10, 2019

@knownasilya looks like it needs a rebase?

@knownasilya
Copy link
Contributor Author

@btecu that's done haha

@knownasilya knownasilya reopened this Nov 10, 2019
@knownasilya
Copy link
Contributor Author

ops, accidentally closed.

@knownasilya
Copy link
Contributor Author

Anyone know how to run tests for a specific package?

@knownasilya
Copy link
Contributor Author

Ok got that, but now getting Uncaught Error: Could not find module @glimmer/compiler required by: @glimmer/opcode-compiler which seems weird..

@pzuraq
Copy link
Contributor

pzuraq commented Nov 10, 2019

Checkout the broccoli build pipeline, it pulls in a number of Glimmer packages but not all of them. May need to be tweaked.

@knownasilya
Copy link
Contributor Author

knownasilya commented Nov 10, 2019

@pzuraq that helped. Now stuck on Uncaught Error: Could not find module simple-html-tokenizer required by: @glimmer/syntax and I tried adding it to a few places but no luck.

@bekzod
Copy link
Contributor

bekzod commented Jan 18, 2020

can be closed, 0.46.0 update in master 9bc32be

@locks
Copy link
Contributor

locks commented Jan 18, 2020

Thank you for your efforts @knownasilya!

@locks locks closed this Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants