-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start GlimmerVM 0.44.0 update #18454
Conversation
hum, will probably need to update glimmer-vm, so not as disconnected as I thought. |
This is something we're planning on working on in the next couple of months, I think we decided it would probably make more sense to try to upgrade to the latest versions of Glimmer directly, but @chancancode and @wycats will have the most context here. Definitely glad you're getting this started though, thank you! |
@knownasilya the last commit you pushed in particular is actually work that will have to be undone - on master, |
@pzuraq do you recommend changing direction to update to latest? |
Yeah, definitely. We won't be able to land an upgrade unless we get to the latest version, since all of the performance fixes we landed in 0.38.5-alpha.3 aren't available again until 0.42.2 |
Yay, fixed a couple tests. |
I have no idea what I'm doing 😂 |
@knownasilya looks like it needs a rebase? |
@btecu that's done haha |
ops, accidentally closed. |
Anyone know how to run tests for a specific package? |
Ok got that, but now getting |
Checkout the broccoli build pipeline, it pulls in a number of Glimmer packages but not all of them. May need to be tweaked. |
@pzuraq that helped. Now stuck on |
can be closed, 0.46.0 update in master 9bc32be |
Thank you for your efforts @knownasilya! |
WIP