[BUGFIX beta] Expose computed getter functions #17855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Apr 3, 2019
A few addons, namely ember-macro-helpers, still rely access to the private `_getter` function on CP descriptors. There's no easy way around this, since ember-macro-helpers can be used to combine _existing_ macros, so this fix exposes the _getter function for the time being until alternative solutions can be made.
pzuraq
force-pushed
the
bugfix/expose-computed-getter-functions
branch
from
eea9858 to
53fc674
Compare
rwjblue
approved these changes
Apr 8, 2019
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few addons, namely ember-macro-helpers, still rely access to
the private
_getterfunction on CP descriptors. There's noeasy way around this, since ember-macro-helpers can be used to
combine existing macros, so this fix exposes the _getter function
for the time being until alternative solutions can be made.