-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX release] fix issue with unchaining ChainNodes #15849
Conversation
Can you cherry pick the failing test commits here so that we can confirm they are passing? |
Can you confirm that the regression this fixes is in 2.16? If so, can you prefix the fixing commit with |
done |
accidentally closed it :P |
Thank you! |
This is poor root cause analysis, remove should never be called unbalanced, we still don't know the cause of the original regression this is just masking the symptom. |
we need to find the commit that caused the regression, this fix is just hiding the issue, we must have changed something around chains being overriden during extend or finish chains |
@bekzod can you git bisect to find the regressing commit? this fix is no good, it is just hiding the unbalanced watch/unwatch. This is going to cause other more subtle bugs. |
@krisselden roger that |
found offending commit 0c72faa |
will checkout why it is happening later today |
fix for #15845 #15836