[BUGFIX release] Enable linking ember-source without prod files. #14975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to these changes, in order to `npm link ember-source` you must run a production build of Ember. This is because of the list of files that we provide to `stew.find` (now `Funnel`) includes `ember.prod.js` and `ember.min.js`. This commit does two main things: * Remove usage of `stew.find` (and therefore remove `broccoli-stew` as a dep). It is likely that `stew.find` will be deprecated (stefanpenner/broccoli-stew#122). * Only provide the list of files that are present to the `Funnel` `files` listing. Before this change the following would throw an error: ``` git clone [email protected]:emberjs/ember.js.git ember-canary cd ember-canary yarn install ./node_modules/.bin/ember build --environment=development yarn link cd .. ember new test-app --yarn cd test-app yarn link ember-source ember s ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to these changes, in order to
npm link ember-sourceyou must run a production build of Ember. This is because of the list of files that we provide tostew.find(nowFunnel) includesember.prod.jsandember.min.js.This commit does two main things:
stew.find(and therefore removebroccoli-stewas a dep). It is likely thatstew.findwill be deprecated (find is just strange, I think we should deprecate stefanpenner/broccoli-stew#122).Funnelfileslisting.Before this change the following would throw an error: