[Glimmer2] Migrate local lookup tests #13345
Conversation
|
Assigning to myself for review, will try to review tonight. |
|
I'm unsure what |
| export default function buildOwner(props) { | ||
| let Owner = EmberObject.extend(RegistryProxy, ContainerProxy, { | ||
| init() { | ||
| this._super(...arguments); | ||
| let registry = new Registry(this._registryOptions); | ||
| let registry = new Registry(this._registryOptions || { | ||
| resolver: buildResolver() |
There was a problem hiding this comment.
I don't think that all tests should get a local lookup enabled resolver. Especially since the actual patterns for how local lookup will work are still up in the air (see emberjs/rfcs#124). It seems better (to me) to inline this change, and the resolver above in the local-lookup-test file until those things are settled...
|
We should also update |
|
Got rid of When you say pass in the source, are you talking about |
Yes, I meant |
|
This is looking good, I see you still have it labeled as |
asakusuma
changed the title
|
@rwjblue ok I removed the WIP as I have attempted to migrate all the local lookup tests now. Except for the one test that was for when |
|
@asakusuma - I believe this file should be deleted and a symlink setup (to match the other sets of ember-glimmer / ember-htmlbars integration tests. Also, the commit still has Let me know when ready for the next round of review... |
|
@rwjblue ready for review. I deleted the old test, but the parent folder of the new test is already symlinked. |
|
Ahh, I see, I didn't realize the parent folder was symlinked. Thank you for pointing that out. |
|
Thank you @asakusuma! |
Not sure if this is the right way to simulate the resolver going forward.