[Glimmer2] Port {{loc}} helper test to ember-glimmer
#13129
Conversation
| Ember.STRINGS = this.oldString; | ||
| } | ||
|
|
||
| ['@test it lets the original value through by default']() { |
There was a problem hiding this comment.
These tests should go through the "The I-N-U-R cycle" mentioned in #13127.
There was a problem hiding this comment.
Woops, right. Will fix that, thanks.
There was a problem hiding this comment.
Seems like this only needs to check initial render and no-op rerender, not update and reset. Does that seem correct?
code0100fun
force-pushed
the
glimmer-loc-helper
branch
from
e635334 to
f10f030
Compare
|
It seems OK to punt on, but this should likely be testing the bound behaviors as well, which do exist: https://ember-twiddle.com/0ec0748d515ec3b87414?openFiles=application.controller.js%2C It seems an oversight that there are no tests for those cases. Followup issue: #13132 |
|
@mixonic, I'll work on adding some tests for the bound params. |
Also implements helper in Glimmer. Only tested initial render and no-op rerender because the helper does not accept any bound attributes.
code0100fun
force-pushed
the
glimmer-loc-helper
branch
from
f10f030 to
91086b7
Compare
[Glimmer2] Port `{{loc}}` helper test to `ember-glimmer`
|
Thanks! @code0100fun! Please send a follow up PR for @mixonic's request 😄 |
Also implements helper in Glimmer