Use model name instead of factory in data adapter #11346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,6 +93,20 @@ export default EmberObject.extend({ | |||
| attributeLimit: 3, | |||
|
|
|||
| /** | |||
| * A change in Ember and Ember Data | |||
| * required string model names to be passed | |||
| * around instead of the actual factories. | |||
There was a problem hiding this comment.
Can you note the version? beta.18. It will make it easier to know when this should be stripped.
|
seems good |
|
Added the ED version. Should I prefix the commit with [BUGFIX beta]? It's not really a bug fix but the sooner we can get it into a release the better. |
This was referenced Jun 4, 2015
rwjblue
added a commit
that referenced
this pull request
Jun 4, 2015
Use model name instead of factory in data adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent PR changed Ember Data to require passing model names to store methods instead of factories.
This passes the model name as a second argument to
getRecordsto stay backwards compatible.