Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSCS rule (getTokenPosByRangeStart was removed upstream). #10747

Merged
merged 4 commits into from
Mar 28, 2015

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Mar 28, 2015

Fixes #10743.

@hzoo
Copy link

hzoo commented Mar 28, 2015

Also, the token.assert methods are pretty nice as well - https://github.com/jscs-dev/node-jscs/blob/master/lib/rules/disallow-spaces-in-function-declaration.js. So for the custom rule you could use errors.assert.noWhitespaceBetween().

And you won't need var tokens = file.getTokens(); anymore.

rwjblue added a commit that referenced this pull request Mar 28, 2015
Fix JSCS rule (getTokenPosByRangeStart was removed upstream).
@rwjblue rwjblue merged commit 85550ca into emberjs:master Mar 28, 2015
@rwjblue
Copy link
Member Author

rwjblue commented Mar 28, 2015

@hzoo - Awesome! Will update shortly...

@rwjblue rwjblue deleted the fix-jscs-rule branch March 28, 2015 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No method getTokenPosByRangeStart causing build to fail
2 participants