beforeModel receives incorrect params during redirect

[ef4]

Here's a minimal JSBin that demonstrates the problem:

http://jsbin.com/iZArAs/2/edit?html,js,output

Click between "One" and "Two". You'll see that the beforeModel hook fires twice during each transition, and the second time it fires with incorrect params (it receives the params of the current route, not the new destination route).

Ideally it would not fire twice (see #3056 ). But as long as it's going to fire twice, it needs to at least fire with the correct parameters.

[machty]

Sorry this has been so inactive for so long; I'm working on router params stuff right now and this does seem related to some other problems I've noticed.

[machty]

Update: tests are passing for this in my router.js refactor: https://github.com/tildeio/router.js/blob/refactor/tests/tests.js#L3197

[machty]

fwiw the solution will be to not refire beforeModel hook.

[machty]

Fixed by #4008