Router redirects should not abort transactions

[wagenet]

This means that even if the redirect is in the same tree we have to exit and re-enter all of the parents.

[stefanpenner]

👍

[machty]

This seems good. I guess this is how pre-facelift stuff worked, right?

[stefanpenner]

On redirect, we should likely, fulfill with something that correctly conveys final resting point.

To support something like "abort" or "unauthorized", the rejection case may be valid. If that is decided, we may want to explore throwing specific routing errors (ala Router.ForbiddenError or Router.UnauthorizedError).

The key being, if we overload the rejections for both exceptional and flow control, we must still be able to distinguish the difference, and handle/swallow/report accordingly.

(@machty I edited my comment, hopefully it is slightly more coherent)

[machty]

@stefanpenner i don't quite follow your comment about Router.Forbidden... say more?

[wagenet]

@stefanpenner, @machty This seems like a big issue. What's the plan to address this?

[machty]

As i mentioned in the call, this is a very blanket and not totally accurate issue, and many of the instances of this are already fixed. I need some more specific examples when this does not work (and there are some examples in other issues that I'll be working on over the next few days). But just so we're clear, it's not like this is the definite behavior for all transitions; afaik, there's just a few more corner cases to nail.

[wagenet]

@machty, any more recent thoughts on this?

[machty]

The latest on this is what I wrote here

[machty]

I can say pretty confidently that this will entirely cease to be an issue with my router.js refactor.

[machty]

This is megafixed via #4008

[Bargs]

If this issue was fixed at some point, it seems like there might have been a regression. I've run into the same behavior described in #3163. I have a transitionTo the login page in my application route's model hook which conditionally fires if an ajax request says the user is unauthenticated. It's a fairly simple scenario without any query params or anything. On page load, the application route hooks get called twice, once on the initial transition and again after the first transition is aborted by redirecting to the login page.

The transition log looks like this:

DEBUG: -------------------------------
DEBUG: Ember      : 1.13.3
DEBUG: Ember Data : 1.13.5
DEBUG: jQuery     : 2.1.3
DEBUG: -------------------------------
Attempting URL transition to /
Preparing to transition from '' to ' index'
Transition #0: application: calling beforeModel hook
Transition #0: application: calling deserialize hook
Attempting transition to login
Transition #0: index: transition was aborted
Transition #1: application: calling beforeModel hook
Transition #1: application: calling deserialize hook
Transition #0: detected abort.
Attempting transition to login
Transition #1: application: calling afterModel hook
Transition #1: login: calling beforeModel hook
Transition #1: login: calling deserialize hook
Transition #1: login: calling afterModel hook
Transition #1: Resolved all models on destination route; finalizing transition.
Transitioned into 'login'
Transition #1: TRANSITION COMPLETE.

[msounthar]

@Bargs I am facing the same issue, Were you able to resolve it?

[Bargs]

I believe I had to work around it by saving a variable on the first load that I could conditionally check for to avoid taking actions on the second load. I don't work on this application anymore though so I don't know if it's been fixed in future versions.

[msounthar]

@Bargs Thanks!

[musterjunk]

I am seeing this behaviour on routes as well. env: on build cli 3.13.2 node 12.14.0 and os lunix x64