Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Typo in optional feature detection (for deprecation) #19377

Closed
rwjblue opened this issue Feb 3, 2021 · 0 comments · Fixed by #19378
Closed

[Bug] Typo in optional feature detection (for deprecation) #19377

rwjblue opened this issue Feb 3, 2021 · 0 comments · Fixed by #19378

Comments

@rwjblue
Copy link
Member

rwjblue commented Feb 3, 2021

There is a typo here:

!optionalFeatures.isFeatureEnabled('template-only-glimmer-compoents')

This was introduced with #19372, and causes the following error for all addons:

TypeError: Cannot read property 'default' of undefined
    at Class.isFeatureEnabled (/home/runner/work/ember-m3/ember-m3/node_modules/@ember/optional-features/index.js:68:57)
    at Class.included (/home/runner/work/ember-m3/ember-m3/node_modules/ember-source/lib/index.js:146:27)
    at Class.superWrapper [as included] (/home/runner/work/ember-m3/ember-m3/node_modules/core-object/lib/assign-properties.js:34:20)
    at project.addons.forEach (/home/runner/work/ember-m3/ember-m3/node_modules/ember-cli/lib/broccoli/ember-app.js:634:15)
    at Array.forEach (<anonymous>)
    at EmberAddon._notifyAddonIncluded (/home/runner/work/ember-m3/ember-m3/node_modules/ember-cli/lib/broccoli/ember-app.js:632:25)
    at new EmberApp (/home/runner/work/ember-m3/ember-m3/node_modules/ember-cli/lib/broccoli/ember-app.js:138:10)
    at new EmberAddon (/home/runner/work/ember-m3/ember-m3/node_modules/ember-cli/lib/broccoli/ember-addon.js:61:5)
    at module.exports (/home/runner/work/ember-m3/ember-m3/ember-cli-build.js:31:13)
    at Builder.readBuildFile (/home/runner/work/ember-m3/ember-m3/node_modules/ember-cli/lib/models/builder.js:49:14)

(thanks to @hjdivad for the nightly CI failure detection over in ember-m3/ember-m3#999)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant