Merge pull request #17846 from emberjs/template-only-bounds

[BUGFIX beta] Fix template-only components clearing
emberjs · Apr 3, 2019 · 82edd47 · 82edd47
2 parents 919ede7 + 9c98690
commit 82edd47
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 3 deletions.
diff --git a/packages/@ember/-internals/glimmer/lib/component-managers/input.ts b/packages/@ember/-internals/glimmer/lib/component-managers/input.ts
@@ -18,7 +18,7 @@ const CAPABILITIES: ComponentCapabilities = {
   createCaller: true,
   dynamicScope: false,
   updateHook: true,
-  createInstance: false,
+  createInstance: true,
 };
 
 export interface InputComponentState {

diff --git a/packages/@ember/-internals/glimmer/lib/component-managers/root.ts b/packages/@ember/-internals/glimmer/lib/component-managers/root.ts
@@ -83,7 +83,7 @@ export const ROOT_CAPABILITIES: ComponentCapabilities = {
   createCaller: true,
   dynamicScope: true,
   updateHook: true,
-  createInstance: false,
+  createInstance: true,
 };
 
 export class RootComponentDefinition implements ComponentDefinition {

diff --git a/packages/@ember/-internals/glimmer/lib/component-managers/template-only.ts b/packages/@ember/-internals/glimmer/lib/component-managers/template-only.ts
@@ -21,7 +21,7 @@ const CAPABILITIES: ComponentCapabilities = {
   createCaller: false,
   dynamicScope: false,
   updateHook: false,
-  createInstance: false,
+  createInstance: true,
 };
 
 export default class TemplateOnlyComponentManager extends AbstractManager<null, OwnedTemplate>

diff --git a/...s/@ember/-internals/glimmer/tests/integration/components/template-only-components-test.js b/...s/@ember/-internals/glimmer/tests/integration/components/template-only-components-test.js
@@ -105,6 +105,30 @@ moduleFor(
 
       this.assertInnerHTML('hello');
     }
+
+    ['@test it has the correct bounds']() {
+      this.registerComponent('foo-bar', 'hello');
+
+      this.render('outside {{#if this.isShowing}}before {{foo-bar}} after{{/if}} outside', {
+        isShowing: true,
+      });
+
+      this.assertInnerHTML('outside before hello after outside');
+
+      this.assertStableRerender();
+
+      runTask(() => this.context.set('isShowing', false));
+
+      this.assertInnerHTML('outside <!----> outside');
+
+      runTask(() => this.context.set('isShowing', null));
+
+      this.assertInnerHTML('outside <!----> outside');
+
+      runTask(() => this.context.set('isShowing', true));
+
+      this.assertInnerHTML('outside before hello after outside');
+    }
   }
 );