Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doubleClick helper #382

Merged
merged 1 commit into from
Jun 13, 2018
Merged

Add doubleClick helper #382

merged 1 commit into from
Jun 13, 2018

Conversation

mmun
Copy link
Member

@mmun mmun commented Jun 8, 2018

This PR adds a doubleClick helper to simulate double-clicks, similar to the click helper. I'm not sure that it was necessary but I duplicated all the click tests.

Here's a little JSBin I threw together to make sure I got the event ordering correct: http://jsbin.com/pulapatapo/1/edit?html,console,output

The order for a focusable element is

mousedown
focus
focusin
mouseup
click
mousedown
mouseup
click
dblclick

which essentially amounts to two simulated clicks followed by a dblclick event.

@mmun mmun force-pushed the double-click branch 2 times, most recently from 3d90721 to 7673bc5 Compare June 8, 2018 20:07
@mmun
Copy link
Member Author

mmun commented Jun 13, 2018

@rwjblue I worked around the double focus issue. Tests are passing now.

@rwjblue
Copy link
Member

rwjblue commented Jun 13, 2018

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants