Extracts code from Ember and sets minimum ember-cli-babel #1
Conversation
locks
force-pushed
the
string-module
branch
2 times, most recently
from
1562e44 to
d47ff81
Compare
|
ATM I think the tests are probably using |
locks
changed the title
|
Where'd |
|
@locks - status? |
|
@rwjblue cleaning all the relevant repos in the AM |
addon/index.js
Outdated
| deprecate( | ||
| 'loc is deprecated, use an internationalization or localization addon instead.', | ||
| false, | ||
| { id: 'ember-string-utils.loc', until: '3.5.0', url: 'http://babeljs.io/docs/learn-es2015/#template-strings' } |
There was a problem hiding this comment.
Should this be a link to ember-intl or ember-i18n or some other page about the topic?
There was a problem hiding this comment.
Looks good for initial implementation.
We should:
- Create an issue to update the implementation here to avoid duplicating code. e.g. when Ember has the string functionality in it, we do not need to include our own implementation.
- Land this PR
- Update to [email protected]
- Change
index.jsto usename: '@ember/string'instead ofat-ember-string
|
I'm updating |
There was a problem hiding this comment.
Hmm. I don’t think the changes in [email protected] actually allow this yet. The version checker is looking upwards through node_modules to find if a package is present, and I don’t think we actually handle the project itself being the package...
loclocember-cli-babelto version that supports@ember/string