Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup npm pretest #75

Closed
wants to merge 1 commit into from

Conversation

duggiefresh
Copy link

No description provided.

@ryanflorence
Copy link
Contributor

This assumes consumers are using bower, which is maybe true often but not always. What's the reasoning?

Sent from my iPhone

On Jul 15, 2014, at 12:57 PM, Doug Yun [email protected] wrote:

You can merge this Pull Request by running

git pull https://github.com/duggiefresh/ember-qunit adds-bower-install
Or view, comment on, or merge it at:

#75

Commit Summary

Adds "bower install" to npm's postinstall
File Changes

M README.md (1)
M package.json (3)
Patch Links:

https://github.com/rjackson/ember-qunit/pull/75.patch
https://github.com/rjackson/ember-qunit/pull/75.diff

Reply to this email directly or view it on GitHub.

@rwjblue
Copy link
Member

rwjblue commented Jul 16, 2014

I think we might just want to move the bower install, directory clearing, and building into pretest. So test is just the actual testing. npm test will automatically run a pretest script before running the tests so we'll still just be able to npm test the same.

* Removes trailing whitespace in README.
@duggiefresh duggiefresh changed the title Adds "bower install" to npm's postinstall Setup npm pretest Jul 16, 2014
@duggiefresh
Copy link
Author

Sweet. Good call on npm pretest.

@@ -4,7 +4,7 @@
"description": "unit test helpers for ember",
"main": "dist/cjs/main.js",
"scripts": {
"test": "bower install && rm -rf dist && broccoli build dist && karma start --browsers Firefox --single-run"
"pretest": "bower install && rm -rf dist && broccoli build dist && karma start --browsers Firefox --single-run"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you split this up between test and pretest?

"pretest": "bower install && rm -rf dist && broccoli build dist",
"test": "karma start --browsers Firefox --single-run"

@rwjblue
Copy link
Member

rwjblue commented Oct 28, 2014

Closing in favor of #100.

@rwjblue rwjblue closed this Oct 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants