Make throw/assertion stack traces useful #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a great step in the right direction. 👍 |
stefanpenner
force-pushed
the
make-stack-traces-useful
branch
2 times, most recently
from
332bc02 to
381012e
Compare
|
test failures look unrelated to this... But i'll investigate in the AM |
|
Not sure what needs to be confirmed RE: QUnit. assert.pushResult is definitely public... |
|
Also, LGTM. |
stefanpenner
force-pushed
the
make-stack-traces-useful
branch
4 times, most recently
from
4120664 to
7028f4b
Compare
stefanpenner
force-pushed
the
make-stack-traces-useful
branch
from
7028f4b to
04beda0
Compare
|
@rwjblue this PR also fixes CI/tests |
trentmwillis
approved these changes
Jul 20, 2017
stefanpenner
force-pushed
the
make-stack-traces-useful
branch
from
80eb2de to
48b663a
Compare
|
@rwjblue / @trentmwillis either of you guys got time to release. I think this can be a minor version. |
stefanpenner
commented
Jul 20, 2017
| @@ -1,6 +1,30 @@ | |||
| import Ember from 'ember'; | |||
| import QUnit from 'qunit'; | |||
|
|
|||
| function unhandledRejectionAssertion(current, error) { | |||
There was a problem hiding this comment.
part 1/2 of the important bit of code:
stefanpenner
commented
Jul 20, 2017
| @@ -19,6 +43,6 @@ export default Ember.Test.Adapter.extend({ | |||
| }, | |||
|
|
|||
| exception(error) { | |||
| QUnit.config.current.assert.ok(false, Ember.inspect(error)); | |||
| unhandledRejectionAssertion(QUnit.config.current, error); | |||
There was a problem hiding this comment.
part 2/2 of the important bit of code:
|
getting trolled by something strange, where some bower deps have an invalid ember.debug.js..... @rwjblue any ideas? I opened a dedicated tracking issue -> emberjs/ember.js#15533 |
stefanpenner
force-pushed
the
make-stack-traces-useful
branch
from
48b663a to
2707061
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
before:
after: