Strict mode deps #1098
Merged
Strict mode deps #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
strict-mode-deps
branch
from
3d1c932 to
370a1f5
Compare
NullVoxPopuli
commented
Jun 12, 2023
| @@ -1,11 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
moved(ish) to the test-types directory
NullVoxPopuli
commented
Jun 12, 2023
| "pnpm": { | ||
| "peerDependencyRules": { | ||
| "ignoreMissing": [ | ||
| "webpack" |
There was a problem hiding this comment.
added because ember-qunit depends on ember-source, which declared webpack as a peerDependency.
This makes sense for apps, but not for v2 addons.
The webpack peerdep in ember-source will also go away once it itself is converted to a v2 addon
…e-effect of ember-qunit depending on v1 addons
… not interfere with the peer requirements of the addon
NullVoxPopuli
force-pushed
the
strict-mode-deps
branch
from
370a1f5 to
ebe8d32
Compare
wagenet
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A consequence of enabling this is that is I found out that the
addonhas a devDep onember-resolver, which was just used for the type tests -- and that's it.To prevent adding bloat to the
addon, I moved the type tests to their own workspace, updated the workflow for those type tests, and while I was at it threw TS 5 and 5.1 on the type check matrix, since we saw that those versions were green via dependabot.To verify that there are no peer issues locally, you can check via: