Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add push-dist workflow #1090

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Jun 12, 2023

ember-qunit is easy because it's not written in typescript, and has separate type-declarations, so there is no build/prepack to worry about

(yet -- this workflow would be a good thing to compare against when the v2 PR is finally merged -- #1064 (this is the end of a 4PR series, with all changes present in that PR until the other 3 are merged))

Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok let's see how it works!

@MelSumner MelSumner merged commit b354545 into emberjs:master Jun 12, 2023
@NullVoxPopuli NullVoxPopuli deleted the add-push-dist-workflow branch June 12, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants