Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pnpm #1063

Merged
merged 4 commits into from
Jun 12, 2023
Merged

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented May 4, 2023

Context, Plan, etc: https://gist.github.com/NullVoxPopuli/eafc7dad6547de5e730098498b829e1f

Requires that this be merged first:

Due to errors discovered in the test-app extraction PR, here: #1061
It was determined that yarn is insufficient for ember-qunit.

This PR migrates the repo to pnpm.

Afterwards, the following are unblocked (in-order):

  1. Extract test app #1062
  2. Convert to native package #1064

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review May 4, 2023 00:59
@@ -0,0 +1,3 @@
packages:
- addon
- test-app
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick

At this stage, we don't have the test-app package yet. I'd have added line 3 in #1062. We can merge this PR as is, since (I think) pnpm ignores entries corresponding to packages that don't exist yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick

In #1060, I noticed you had to update the volta entry in the root package.json.

ember-qunit/package.json

Lines 15 to 18 in 5862d31

"volta": {
"node": "16.20.0",
"yarn": "1.22.19"
}

I'm guessing that, in this pull request, the entry should have similarly been updated again, by replacing yarn with pnpm? (Maybe this happens in a later PR. At any rate, we can merge the PR as is.)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks!
For conflict management, i'd like to do that in the test-app extraction pr.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this stage, we don't have the test-app package yet.

I missed this comment.

I extracted code from PR #1062 -- this this #1063, is meant for easier review of the whole process only, and isn't itself an atomic change.

Make gitignore work for all directories

Add root package.json

Update CI

Use previously upgraded node
@MelSumner MelSumner merged commit 5dfd2cf into emberjs:master Jun 12, 2023
@NullVoxPopuli NullVoxPopuli deleted the switch-to-pnpm-standalone branch June 12, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants