Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove View Tree #941

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Remove View Tree #941

merged 1 commit into from
Jun 12, 2019

Conversation

nummi
Copy link
Collaborator

@nummi nummi commented Feb 10, 2019 •
edited
Loading

@nummi nummi mentioned this pull request Feb 10, 2019
Closed
4 tasks
@nummi nummi added the octane label Mar 27, 2019
@nummi nummi changed the title WIP: Remove View Tree Remove View Tree Mar 27, 2019
@nummi nummi force-pushed the remove-view-tab branch from ab5ca59 to d27088f Compare April 17, 2019 19:03
@locks locks self-assigned this May 3, 2019
@nummi nummi force-pushed the remove-view-tab branch from d27088f to b72998d Compare June 4, 2019 23:42
RobbieTheWagner
RobbieTheWagner approved these changes Jun 12, 2019
View reviewed changes
Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

rwjblue
rwjblue approved these changes Jun 12, 2019
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👯‍♂ 👯 🕺

@nummi nummi force-pushed the remove-view-tab branch from b72998d to c77f215 Compare June 12, 2019 17:55
@RobbieTheWagner RobbieTheWagner merged commit 3758aeb into emberjs:master Jun 12, 2019
@nummi nummi deleted the remove-view-tab branch June 12, 2019 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

@rwjblue rwjblue rwjblue approved these changes

Assignees

@locks locks

Labels
enhancement octane
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nummi @rwjblue @RobbieTheWagner @locks