Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alt/option click to toggle children in component tree #925

Merged

Conversation

nummi
Copy link
Collaborator

@nummi nummi commented Jan 27, 2019

We can currently expand/collapse ALL items but not in any granular fashion without a lot of clicking. This can be a pain to explore large component trees. With this PR I'm proposing we copy the MacOS style (I'm sure other platforms have something similar) of expanding/collapsing children nodes by alt/option clicking on a disclosure triangle.

image

Option click {{es-header}} and it will fold and so will all the children.

@rwjblue
Copy link
Member

rwjblue commented Jan 29, 2019

Seems neat!

@nummi nummi force-pushed the key-to-toggle-component-children branch 2 times, most recently from 774005b to fed4d2a Compare January 30, 2019 00:06
@nummi nummi changed the title WIP: alt/option click to toggle children in component tree alt/option click to toggle children in component tree Jan 30, 2019
@nummi nummi force-pushed the key-to-toggle-component-children branch 3 times, most recently from 9b358be to 4668c62 Compare January 31, 2019 21:12
@nummi nummi force-pushed the key-to-toggle-component-children branch from 4668c62 to 2623ee5 Compare February 1, 2019 20:56
@RobbieTheWagner RobbieTheWagner merged commit 4e2e872 into emberjs:master Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants