Ember 3.5.1, lots of template lint fixes #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbieTheWagner
requested review from
thorsteinsson,
teddyzeenny and
pbishop16
rwjblue
requested changes
Dec 14, 2018
| @@ -30,6 +31,8 @@ | |||
| "0.0.0" | |||
| ], | |||
| "devDependencies": { | |||
| "@ember/jquery": "^0.5.2", | |||
There was a problem hiding this comment.
Adding this is 👍, but it will mean that you need to tweak all of your Ember < 2.8 ember-try scenarios to bring jQuery@2.
There was a problem hiding this comment.
Checkout this 2.4 scenario:
{
name: 'ember-lts-2.4',
env: {
EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'jquery-integration': true }),
},
bower: {
dependencies: {
ember: 'components/ember#lts-2-4',
},
resolutions: {
ember: 'lts-2-4',
},
},
npm: {
devDependencies: {
'@ember/jquery': '^0.5.1',
'ember-source': null,
'jquery': '^2.2.4',
},
},
},There was a problem hiding this comment.
Thanks! Just made the changes. Hopefully tests will pass now 🤞
| @@ -1,40 +1,168 @@ | |||
| {{#if isRight}} | |||
| {{#if isExpanded}} | |||
| <svg width="16px" height="14px" viewBox="0 0 16 14" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> | |||
| <svg | |||
There was a problem hiding this comment.
Move this to a file an use svg-jar?
rwjblue
approved these changes
Dec 14, 2018
pbishop16
approved these changes
Dec 14, 2018
cyril-sf
pushed a commit
to cyril-sf/ember-inspector
that referenced
this pull request
Mar 30, 2022
* Ember 3.5.1, lots of template lint fixes * Remove deprecated propertyDidChange * Set jquery version to 2.x for Ember 2.7 * Ignore lint for one computed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of template lint issues here. Still disabled a bunch of rules for us to fix later, but tried to fix a lot of the formatting ones.