-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jQuery, use flatpickr instead of pikaday #842
Conversation
@teddyzeenny the one test failure I am getting here is related to https://github.com/emberjs/ember-inspector/blob/master/tests/acceptance/object-inspector-test.js#L564.
It seems |
ember-pikaday was using jQuery internally, so we had to move away from it. I chose flatpickr, but we could use anything else. I'm having trouble getting the tests to pass currently. Resolves #590
3d18854
to
f4f6170
Compare
Have you tried calling other events manually? I see a |
@nummi I fixed that, everything works, I just need someone to review the PR. |
I'll review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this locally and it looks like flatpickr is functioning as intended. I loaded up http://ember-flatpickr.shipshape.io/ and was able to inspect the dates on the date picker component using it. Hitting 'esc' closed the picker as expected. 👍
* Remove jQuery, use flatpickr instead of pikaday ember-pikaday was using jQuery internally, so we had to move away from it. I chose flatpickr, but we could use anything else. I'm having trouble getting the tests to pass currently. Resolves #590 * Fix test * Check ember version before removing jQuery Co-Authored-By: Robert Jackson <[email protected]> * Stop trying to use ember-native-dom-dispatcher * Remove unused project * Add travis_retry to attempt to retry builds automatically
* Remove jQuery, use flatpickr instead of pikaday ember-pikaday was using jQuery internally, so we had to move away from it. I chose flatpickr, but we could use anything else. I'm having trouble getting the tests to pass currently. Resolves emberjs#590 * Fix test * Check ember version before removing jQuery Co-Authored-By: Robert Jackson <[email protected]> * Stop trying to use ember-native-dom-dispatcher * Remove unused project * Add travis_retry to attempt to retry builds automatically
ember-pikaday was using jQuery internally, so we had to move away from it. I chose flatpickr, but we could use anything else. I'm having trouble getting the tests to pass currently.
Resolves #590