Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Context menu item for "Inspect Ember Component" #788

Closed
wants to merge 3 commits into from

Conversation

thorsteinsson
Copy link
Member

image

This adds "Inspect Ember Component" context menu item to all pages when Ember has been detected. It adds the object id to the query string which keeps the component selected between page refreshes.

Things to improve:

  • Add tests.
  • Scroll to the selected component in the inspector.
  • Show a message when the ember inspector is not visible (tell the user to open the inspector, not possible with code).
  • Show a message when a component is not found.

@thorsteinsson
Copy link
Member Author

thorsteinsson commented Apr 18, 2018

@Bestra and I paired on this at the Emberconf contributors workshop for #689.

@RobbieTheWagner
Copy link
Member

@thorsteinsson @Bestra @nummi does anyone have cycles to help get this over the finish line?

@Bestra
Copy link
Contributor

Bestra commented May 1, 2018

@rwwagner90 I think I'll have at least a half day to work on it this Friday. @thorsteinsson would you be okay with me adding some commits to your branch if I get the time?

@thorsteinsson
Copy link
Member Author

Of course, go ahead. I've been so busy at work, hoping to get some time tomorrow.

@RobbieTheWagner
Copy link
Member

Is anyone actively working on this?

@Bestra
Copy link
Contributor

Bestra commented Jul 27, 2018

@rwwagner90 I'd like to close this PR in favor of #843

@Bestra
Copy link
Contributor

Bestra commented Jul 27, 2018

@thorsteinsson I'm closing this one in favor of #843, which is essentially this PR with two extra commits from me. Good work!

@Bestra Bestra closed this Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants