Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force startup-wrapper logic to run less times #1848

Merged
merged 2 commits into from
Dec 27, 2021

Conversation

RobbieTheWagner
Copy link
Member

Using { once: true } in the listener seems to fix our infinite number of calls. Fixes #1634

Using `{ once: true }` in the listener seems to fix our infinite number of calls. Fixes #1634
@DanMonroe
Copy link

@rwwagner90 I have a local version that both fixes the maximum call stack error AND the tests pass. Here is what I changed:

startup_wrapper.js:
change
window.EmberInspector = requireModule('ember-debug/main')['default'];

to

let emberDebugMainModule = requireModule('ember-debug/main');
if (!emberDebugMainModule['default']) {
  return;
}
window.EmberInspector = emberDebugMainModule['default'];

@RobbieTheWagner RobbieTheWagner merged commit 26a3926 into master Dec 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-maximum-call-stack branch December 27, 2021 03:25
patricklx pushed a commit to patricklx/ember-inspector that referenced this pull request Sep 19, 2022
* Force startup-wrapper logic to run less times.

Using `{ once: true }` in the listener seems to fix our infinite number of calls. Fixes emberjs#1634

* Update startup-wrapper.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application that accesses global Ember fails to start after browser refresh
2 participants