Don't rely on Ember.EmberInspectorDebugger

[sandstrom]

Closes #1758

No idea if this is the best way of solving it.

But since we're moving away from the Ember global a change such as this seemed reasonable, and respects the existing code (this change is minimal), since window.EmberInspector already existed.

Deleted Ember.EmberInspectorDebugger altogether, since it's not used elsewhere and I cannot find any code in Github (across all projects) that rely on it.

https://github.com/search?q=EmberInspectorDebugger&type=code

[RobbieTheWagner]

Thanks @sandstrom! You're right, I am not sure Ember.EmberInspectorDebugger is used anywhere. I think the idea was it would be stored on Ember rather than the window, but I am not sure why we were doing both. It seems like that code was from many years ago, so I think changing it is fine.

[sandstrom]

@rwwagner90 can you trigger re-run of actions? https://github.com/emberjs/ember-inspector/runs/3975937135?check_suite_focus=true seems like it's unrelated to this code, no? tests are only failing on beta

[RobbieTheWagner]

@sandstrom I'm seeing the same issues in #1759

Seems like something broke with ember test helpers in general

[RobbieTheWagner]

@sandstrom I think that issue has been fixed now. Can you please rebase with master?

[sandstrom]

@rwwagner90 Alright, new attempt 😄

[sandstrom]

@rwwagner90 Do you know anyone with write-access who can merge this?

[RobbieTheWagner]

@sandstrom I have write access, I'm trying to get feedback from @chancancode on if there are any drawbacks to this change.

[chancancode]

Seems fine to me