fixed all the beta build test failures #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancancode
reviewed
Oct 15, 2021
chancancode
reviewed
Oct 15, 2021
chancancode
reviewed
Oct 15, 2021
chancancode
reviewed
Oct 15, 2021
chancancode
reviewed
Oct 15, 2021
chancancode
reviewed
Oct 15, 2021
| app = Application.create(config.APP); | ||
| app = Application.create({ | ||
| ...config.APP, | ||
| modulePrefix: config.modulePrefix, |
There was a problem hiding this comment.
Suggested change
| modulePrefix: config.modulePrefix, |
There was a problem hiding this comment.
@chancancode
We do need to have modulePrefix
Otherwise, there is error
Error: Assertion Failed: modulePrefix must be defined
Seems that podModulePrefix is optional. I will leave it off.
|
Nice. Thank you! Sorry for the noise, tried to fix this from mobile while in transit 🙃 feel free to discard/squash/force push to the branch |
Update tests/helpers/setup-ember-debug-test.js Update tests/helpers/setup-ember-debug-test.js Update tests/helpers/setup-ember-debug-test.js Update tests/helpers/setup-ember-debug-test.js Update tests/helpers/setup-ember-debug-test.js
michaelbdai
force-pushed
the
bdai/beta
branch
from
0be270b to
b782864
Compare
fix object inspector test
michaelbdai
force-pushed
the
bdai/beta
branch
from
4b2870a to
dcbc943
Compare
michaelbdai
changed the title
michaelbdai
commented
Oct 16, 2021
| @@ -117,6 +117,9 @@ | |||
| "webpack": "^5.51.1", | |||
| "yauzl": "^2.10.0" | |||
| }, | |||
| "resolutions": { | |||
| "socket.io": "4.2.0" | |||
There was a problem hiding this comment.
this change fixes this issue
https://discord.com/channels/480462759797063690/483601670685720591/898312581339553822
RobbieTheWagner
approved these changes
Oct 17, 2021
|
Thanks so much for your work on this @michaelbdai! |
patricklx
pushed a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
* fix beta build * Update tests/helpers/setup-ember-debug-test.js Update tests/helpers/setup-ember-debug-test.js Update tests/helpers/setup-ember-debug-test.js Update tests/helpers/setup-ember-debug-test.js Update tests/helpers/setup-ember-debug-test.js Update tests/helpers/setup-ember-debug-test.js * fix all failing tests fix object inspector test Co-authored-by: Bing Dai <[email protected]> Co-authored-by: Godfrey Chan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixed all the beta build test failures
Screenshots